Re: [PATCH v3 17/17] Documentation: add documentation for 'git interpret-trailers'

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2014, 20:30 UTC
Message-ID: <xmqq1tzqjzu3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140129.210102.2157679962537036887.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 5 quoted lines

>> I find it a bad taste to allow unbound set of <token> on the LHS of
>> '=' on the command line, but that is a separate issue in the design,
>> not in the documentation of the design.
>
> I don't understand this sentence, sorry.

It is a bad design taste to structure the command line argument in such a way that it takes

	git cmd xyzzy=frotz nitfol=rezrov some other args

where these 'xyzzy', 'nitfol', etc. form an unbound set. It prevents future enhancements to the command from allowing anything that contain '=' in "some other args" part.

Allowing not just '=' but also ':' makes it even worse.

But these are issues in the design itself. Not the issue in the patch 17/17 that is trying to document the design. This patch under discussion documents the bad design correctly ;-)