Re: [PATCH v3] git-p4: add "--path-encoding" option

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2015, 23:13 UTC
Message-ID: <xmqqk2sbt5kv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1441059026-66814-2-git-send-email-larsxschneider@gmail.com>

larsxschneider@gmail.com writes:

> From: Lars Schneider <larsxschneider@gmail.com>
>

Here is a space for you to describe what it does and why it is a good idea to have it.

Show 5 quoted lines

> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>  Documentation/git-p4.txt        |  5 +++++
>  git-p4.py                       |  6 ++++++
>  t/t9821-git-p4-path-encoding.sh | 38 ++++++++++++++++++++++++++++++++++++++

I'll move this to 9822, as 9821 is taken by another git-p4 test, while queuing.

Show 13 quoted lines

> diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
> index 82aa5d6..14bb79c 100644
> --- a/Documentation/git-p4.txt
> +++ b/Documentation/git-p4.txt
> @@ -252,6 +252,11 @@ Git repository:
>  	Use a client spec to find the list of interesting files in p4.
>  	See the "CLIENT SPEC" section below.
>  
> +--path-encoding <encoding>::
> +	The encoding to use when reading p4 client paths. With this option
> +	non ASCII paths are properly stored in Git. For example, the encoding
> +	'cp1252' is often used on Windows systems.
> +

Is this something that needs to be consistently given while interacting with the same P4 depot (in which case you may want to allow this to be given only once, record the value in the config and never allow it to be updated once it is set, or something)?

Thanks.