Re: [PATCH v3] git-p4: add "--path-encoding" option

From: Torsten Bögershausen <tboegi@web.de>
Date: Sep 1, 2015, 14:35 UTC
Message-ID: <55E5B798.40108@web.de>
In-Reply-To: <6BD3F017-37E4-4677-BCCE-D84E7031B780@gmail.com>

On 2015-09-01 14.47, Lars Schneider wrote:

Show 16 quoted lines

>>> +test_expect_success 'Create a repo containing iso8859-1 encoded paths' '
>>> >> +	cd "$cli" &&
>>> >> +
>>> >> +	ISO8859="$(printf "$UTF8_ESCAPED" | iconv -f utf-8 -t iso8859-1)" &&
>>> >> +	>"$ISO8859" &&
>>> >> +	p4 add "$ISO8859" &&
>>> >> +	p4 submit -d "test commit"
>>> >> +'
>> > Sorry for being persistant,
>> > but you can't create files with names that  are ISO-8859-1 encoded under Mac OS,
>> > we end up like this:
>> > 
>> > a-%E4_o-%F6_u-%FC.txt
> You are right. However, my goal is not to create a file with ISO-8859-1 characters in Mac OS. My goal is to create this file in Perforce and this approach seems to work.
> 
>> >

But this line creates a file, doesn't it ?

>"$ISO8859" &&

(I just wonder how this works on you machine )

And, may be, we could fill the file with some content, to be double-sure that the file name conversion works with Perforce ?

like echo content >"$ISO8859" &&

and test the content later ?