Re: [PATCH v3] git-p4: add "--path-encoding" option

From: Lars Schneider <larsxschneider@gmail.com>
Date: Sep 1, 2015, 18:55 UTC
Message-ID: <1243E147-EFEC-4D0B-9872-6B9A8BBE7737@gmail.com>
In-Reply-To: <xmqqmvx6rqk7.fsf@gitster.mtv.corp.google.com>

On 01 Sep 2015, at 19:35, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> On 01 Sep 2015, at 01:13, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>>> larsxschneider@gmail.com writes:
>>> 
>>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>> 
>>> 
>>> Here is a space for you to describe what it does and why it is a
>>> good idea to have it.
>> How about this:
>> 
>> Perforce keeps the encoding of a path as given by the originating
>> OS. Git expects paths encoded as UTF-8. Add an option to tell git-p4
>> what encoding Perforce had used for the paths. This encoding is used
>> to transcode the paths to UTF-8. As an example, Perforce on Windows
>> uses “cp1252” to encode path names.
> 
> Very readable.  Does "Perforce on Windows" always use cp1252, or
> is it more correct to say "often uses" here?

Thank you! I don’t know if “always” or “often” is better. On my Windows test system it is “always”… but that’s not a valid sample size :-) I searched the Internet for clues around cp1252 and found that a similar patch was submitted to Mercurial just a month ago. The author seconds my cp1252 observation: http://mercurial.808500.n3.nabble.com/PATCH-stable-convert-use-original-local-encoding-when-converting-from-Perfoce-tp4025088p4025094.html

- Lars