Re: [PATCH v3] git-p4: add "--path-encoding" option
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Sep 1, 2015, 15:02 UTC
- Message-ID
- <3942C6D1-A758-4F50-9865-9D83C5CD9128@gmail.com>
- In-Reply-To
- <55E5B798.40108@web.de>
On 01 Sep 2015, at 16:35, Torsten Bögershausen <tboegi@web.de> wrote:
Show 21 quoted lines
> On 2015-09-01 14.47, Lars Schneider wrote: >>>> +test_expect_success 'Create a repo containing iso8859-1 encoded paths' ' >>>>>> + cd "$cli" && >>>>>> + >>>>>> + ISO8859="$(printf "$UTF8_ESCAPED" | iconv -f utf-8 -t iso8859-1)" && >>>>>> + >"$ISO8859" && >>>>>> + p4 add "$ISO8859" && >>>>>> + p4 submit -d "test commit" >>>>>> +' >>>> Sorry for being persistant, >>>> but you can't create files with names that are ISO-8859-1 encoded under Mac OS, >>>> we end up like this: >>>> >>>> a-%E4_o-%F6_u-%FC.txt >> You are right. However, my goal is not to create a file with ISO-8859-1 characters in Mac OS. My goal is to create this file in Perforce and this approach seems to work. >> >>>> > But this line creates a file, doesn't it ? >> "$ISO8859" && > > (I just wonder how this works on you machine )
I tested it on OS X (HPFS) and Linux (ext4). Can you reproduce problems on your machine? If yes, what is your OS/filesystem?
Show 7 quoted lines
> And, may be, we could fill the file with some content, to be double-sure that > the file name conversion works with Perforce ? > > like > echo content >"$ISO8859" && > > and test the content later ?
OK, I will add this.
Thanks, Lars