Re: [PATCH 1/8] Add basic Coccinelle transforms.

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2016, 02:28 UTC
Message-ID: <xmqqk2i1u3zn.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160607005716.69222-2-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 12 quoted lines

> Coccinelle (http://coccinelle.lip6.fr/) is a program which performs
> mechanical transformations on C programs using semantic patches.  These
> semantic patches can be used to implement automatic refactoring and
> maintenance tasks.
>
> Add a set of basic semantic patches to convert common patterns related
> to the struct object_id transformation.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> I realize the name and location of this file might be suboptimal.
> Suggestions on better locations and filenames would be appreciated.

Once is_null_sha1() is updated to is_null_oid(), the first rewrite definition would become useless, no? I am not sure what the point is to keep this file in our history.

Show 94 quoted lines

>
>  standard.cocci | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
>  create mode 100644 standard.cocci
>
> diff --git a/standard.cocci b/standard.cocci
> new file mode 100644
> index 00000000..0f068252
> --- /dev/null
> +++ b/standard.cocci
> @@ -0,0 +1,83 @@
> +@@
> +expression E1;
> +@@
> +- is_null_sha1(E1.hash)
> ++ is_null_oid(&E1)
> +
> +@@
> +expression E1;
> +@@
> +- is_null_sha1(E1->hash)
> ++ is_null_oid(E1)
> +
> +@@
> +expression E1;
> +@@
> +- sha1_to_hex(E1.hash)
> ++ oid_to_hex(&E1)
> +
> +@@
> +expression E1;
> +@@
> +- sha1_to_hex(E1->hash)
> ++ oid_to_hex(E1)
> +
> +@@
> +expression E1;
> +@@
> +- hashclr(E1.hash)
> ++ oidclr(&E1)
> +
> +@@
> +expression E1;
> +@@
> +- hashclr(E1->hash)
> ++ oidclr(E1)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcmp(E1.hash, E2.hash)
> ++ oidcmp(&E1, &E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcmp(E1->hash, E2->hash)
> ++ oidcmp(E1, E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcmp(E1->hash, E2.hash)
> ++ oidcmp(E1, &E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcmp(E1.hash, E2->hash)
> ++ oidcmp(&E1, E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcpy(E1.hash, E2.hash)
> ++ oidcpy(&E1, &E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcpy(E1->hash, E2->hash)
> ++ oidcpy(E1, E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcpy(E1->hash, E2.hash)
> ++ oidcpy(E1, &E2)
> +
> +@@
> +expression E1, E2;
> +@@
> +- hashcpy(E1.hash, E2->hash)
> ++ oidcpy(&E1, E2)