git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/8] Rename struct diff_filespec's sha1_valid member.

From
Johannes Sixt <j6t@kdbg.org>
Date
Jun 7, 2016, 06:21 UTC
Message-ID
<575667E6.7030509@kdbg.org>
In-Reply-To
<20160607005716.69222-5-sandals@crustytoothpaste.net>
Am 07.06.2016 um 02:57 schrieb brian m. carlson:
Show 37 quoted lines
> Now that this struct's sha1 member is called "oid", update the comment
> and the sha1_valid member to be called "oid_valid" instead.  The
> following Coccinelle semantic patch was used to implement this, followed
> by the transformations in standard.cocci:
>
> @@
> struct diff_filespec *p;
> @@
> - p->sha1_valid
> + p->oid_valid
>
> @@
> struct diff_filespec o;
> @@
> - o.sha1_valid
> + o.oid_valid
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>   combine-diff.c    |  4 ++--
>   diff.c            | 28 ++++++++++++++--------------
>   diffcore-break.c  |  2 +-
>   diffcore-rename.c |  4 ++--
>   diffcore.h        |  2 +-
>   line-log.c        | 10 +++++-----
>   6 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/combine-diff.c b/combine-diff.c
> index f39be434..a20caa80 100644
> --- a/combine-diff.c
> +++ b/combine-diff.c
> @@ -1269,7 +1269,7 @@ static struct diff_filepair *combined_pair(struct combine_diff_path *p,
>   		pair->one[i].path = p->path;
>   		pair->one[i].mode = p->parent[i].mode;
>   		oidcpy(&pair->one->oid, &p->parent[i].oid);
> -		pair->one[i].sha1_valid = !is_null_oid(&p->parent[i].oid);
> +		pair->one->oid_valid = !is_null_oid(&p->parent[i].oid);
Is this transformation correct?
>   		pair->one[i].has_more_entries = 1;
>   	}
>   	pair->one[num_parent - 1].has_more_entries = 0;
-- Hannes
Previous: brian m. carlsonNext: Jeff King
Message 5 of 15 in “Add basic Coccinelle transforms.”
  1. 1/8 Add basic Coccinelle transforms.brian m. carlson, Jun 7, 2016
  2. 2/8 Apply standard object_id Coccinelle transformations.brian m. carlson, Jun 7, 2016
  3. 3/8 Convert struct diff_filespec to struct object_idbrian m. carlson, Jun 7, 2016
  4. 4/8 Rename struct diff_filespec's sha1_valid member.brian m. carlson, Jun 7, 2016
  5. Johannes SixtJun 7, 2016
  6. Jeff KingJun 7, 2016
  7. Junio C HamanoJun 7, 2016
  8. brian m. carlsonJun 7, 2016
  9. 5/8 merge-recursive: convert struct stage_data to use object_idbrian m. carlson, Jun 7, 2016
  10. 6/8 merge-recursive: convert struct merge_file_info to object_idbrian m. carlson, Jun 7, 2016
  11. 7/8 merge-recursive: convert leaf functions to use struct object_idbrian m. carlson, Jun 7, 2016
  12. 8/8 merge-recursive: convert merge_recursive_generic to object_idbrian m. carlson, Jun 7, 2016
  13. Junio C HamanoJun 7, 2016
  14. brian m. carlsonJun 7, 2016
  15. Junio C HamanoJun 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.