git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/8] Add basic Coccinelle transforms.

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jun 7, 2016, 00:57 UTC
Message-ID
<20160607005716.69222-2-sandals@crustytoothpaste.net>

Coccinelle (http://coccinelle.lip6.fr/) is a program which performs mechanical transformations on C programs using semantic patches. These semantic patches can be used to implement automatic refactoring and maintenance tasks.

Add a set of basic semantic patches to convert common patterns related to the struct object_id transformation.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
I realize the name and location of this file might be suboptimal.
Suggestions on better locations and filenames would be appreciated.
 standard.cocci | 83 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100644 standard.cocci
diff --git a/standard.cocci b/standard.cocci
new file mode 100644
index 00000000..0f068252
--- /dev/null
+++ b/standard.cocci
@@ -0,0 +1,83 @@
+@@
+expression E1;
+@@
+- is_null_sha1(E1.hash)
++ is_null_oid(&E1)
+
+@@
+expression E1;
+@@
+- is_null_sha1(E1->hash)
++ is_null_oid(E1)
+
+@@
+expression E1;
+@@
+- sha1_to_hex(E1.hash)
++ oid_to_hex(&E1)
+
+@@
+expression E1;
+@@
+- sha1_to_hex(E1->hash)
++ oid_to_hex(E1)
+
+@@
+expression E1;
+@@
+- hashclr(E1.hash)
++ oidclr(&E1)
+
+@@
+expression E1;
+@@
+- hashclr(E1->hash)
++ oidclr(E1)
+
+@@
+expression E1, E2;
+@@
+- hashcmp(E1.hash, E2.hash)
++ oidcmp(&E1, &E2)
+
+@@
+expression E1, E2;
+@@
+- hashcmp(E1->hash, E2->hash)
++ oidcmp(E1, E2)
+
+@@
+expression E1, E2;
+@@
+- hashcmp(E1->hash, E2.hash)
++ oidcmp(E1, &E2)
+
+@@
+expression E1, E2;
+@@
+- hashcmp(E1.hash, E2->hash)
++ oidcmp(&E1, E2)
+
+@@
+expression E1, E2;
+@@
+- hashcpy(E1.hash, E2.hash)
++ oidcpy(&E1, &E2)
+
+@@
+expression E1, E2;
+@@
+- hashcpy(E1->hash, E2->hash)
++ oidcpy(E1, E2)
+
+@@
+expression E1, E2;
+@@
+- hashcpy(E1->hash, E2.hash)
++ oidcpy(E1, &E2)
+
+@@
+expression E1, E2;
+@@
+- hashcpy(E1.hash, E2->hash)
++ oidcpy(&E1, E2)
Next: brian m. carlson
Message 1 of 15 in “Add basic Coccinelle transforms.”
  1. 1/8 Add basic Coccinelle transforms.brian m. carlson, Jun 7, 2016
  2. 2/8 Apply standard object_id Coccinelle transformations.brian m. carlson, Jun 7, 2016
  3. 3/8 Convert struct diff_filespec to struct object_idbrian m. carlson, Jun 7, 2016
  4. 4/8 Rename struct diff_filespec's sha1_valid member.brian m. carlson, Jun 7, 2016
  5. Johannes SixtJun 7, 2016
  6. Jeff KingJun 7, 2016
  7. Junio C HamanoJun 7, 2016
  8. brian m. carlsonJun 7, 2016
  9. 5/8 merge-recursive: convert struct stage_data to use object_idbrian m. carlson, Jun 7, 2016
  10. 6/8 merge-recursive: convert struct merge_file_info to object_idbrian m. carlson, Jun 7, 2016
  11. 7/8 merge-recursive: convert leaf functions to use struct object_idbrian m. carlson, Jun 7, 2016
  12. 8/8 merge-recursive: convert merge_recursive_generic to object_idbrian m. carlson, Jun 7, 2016
  13. Junio C HamanoJun 7, 2016
  14. brian m. carlsonJun 7, 2016
  15. Junio C HamanoJun 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.