Re: [PATCH 1/8] Add basic Coccinelle transforms.

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jun 7, 2016, 02:31 UTC
Message-ID: <20160607023144.GA72717@vauxhall.crustytoothpaste.net>
In-Reply-To: <xmqqk2i1u3zn.fsf@gitster.mtv.corp.google.com>

On Mon, Jun 06, 2016 at 07:28:28PM -0700, Junio C Hamano wrote:

Show 18 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > Coccinelle (http://coccinelle.lip6.fr/) is a program which performs
> > mechanical transformations on C programs using semantic patches.  These
> > semantic patches can be used to implement automatic refactoring and
> > maintenance tasks.
> >
> > Add a set of basic semantic patches to convert common patterns related
> > to the struct object_id transformation.
> >
> > Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> > ---
> > I realize the name and location of this file might be suboptimal.
> > Suggestions on better locations and filenames would be appreciated.
> 
> Once is_null_sha1() is updated to is_null_oid(), the first rewrite
> definition would become useless, no?  I am not sure what the point
> is to keep this file in our history.

It might not be generally useful to keep forever. I generally have applied this set of transforms after each of the other semantic patches, but I can simply refer to "a standard set of transforms" if you think that's better, or I can post a URL with those somewhere to refer to.

My goal here is simply to avoid needing to include this set of transformations in each commit message, which would tend to bloat it considerably.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204