Re: [PATCH v2 2/2] push: fix --dry-run to not push submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2016, 17:43 UTC
Message-ID: <xmqqk2bvquk1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161117190255.GK66382@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 10 quoted lines

> On 11/17, Stefan Beller wrote:
>> On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams <bmwill@google.com> wrote:
>> 
>> >                                 sha1_array_clear(&commits);
>> > -                               die("Failed to push all needed submodules!");
>> > +                               die ("Failed to push all needed submodules!");
>> 
>> huh? Is this a whitespace change?
>
> That's odd...I didn't mean to add that lone space.

Is that the only glitch in this round? IOW, is the series OK to be picked up as long as I treak this out while queuing?