git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] bug fix with push --dry-run and submodules

From
Stefan Beller <sbeller@google.com>
Date
Nov 17, 2016, 19:01 UTC
Message-ID
<CAGZ79kYC51zC4nF3crtuJXK7uwK=Lh9X8LnRke5C87Vo46Gb+A@mail.gmail.com>
In-Reply-To
<1479408364-150268-1-git-send-email-bmwill@google.com>
On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams <bmwill@google.com> wrote:
Show 5 quoted lines
> v2 of this series is just a small cleanup of removing a nested sub-shell from a
> test and rebasing on the latest version of
> 'origin/hv/submodule-not-yet-pushed-fix'
>
> As stated above this series is based on 'origin/hv/submodule-not-yet-pushed-fix'
an interdiff to v1 would be nice :)

Now t5531 is inconsistent in style, how much time would you estimate to add a commit to refactor that test to follow the style with excessive use of -C for all the other tests and avoiding subshells there, too? (It's mainly Windows that benefits from such a refactoring immediately, but consistency is a really nice feat for the long term code health of the Git project)

Apart from one nit (and this refactoring decision/consistency discussion), the series looks good!

Thanks, Stefan

Previous: Junio C HamanoNext: Brandon Williams
Message 15 of 16 in “bug fix with push --dry-run and submodules”
  1. 0/2 bug fix with push --dry-run and submodulesBrandon Williams, Nov 15, 2016
  2. 1/2 push: --dry-run updates submodules when --recurse-submodules=on-demandBrandon Williams, Nov 15, 2016
  3. Johannes SixtNov 15, 2016
  4. Brandon WilliamsNov 15, 2016
  5. Johannes SixtNov 15, 2016
  6. 2/2 push: fix --dry-run to not push submodulesBrandon Williams, Nov 15, 2016
  7. 0/2 bug fix with push --dry-run and submodulesBrandon Williams, Nov 17, 2016
  8. 1/2 push: --dry-run updates submodules when --recurse-submodules=on-demandBrandon Williams, Nov 17, 2016
  9. 2/2 push: fix --dry-run to not push submodulesBrandon Williams, Nov 17, 2016
  10. Stefan BellerNov 17, 2016
  11. Brandon WilliamsNov 17, 2016
  12. Junio C HamanoNov 22, 2016
  13. Brandon WilliamsNov 22, 2016
  14. Junio C HamanoNov 23, 2016
  15. Stefan BellerNov 17, 2016
  16. Brandon WilliamsNov 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.