Re: [PATCH v2 2/2] push: fix --dry-run to not push submodules
Brandon Williams <bmwill@google.com> writes:
Show 20 quoted lines
> On 11/22, Junio C Hamano wrote:
>> Brandon Williams <bmwill@google.com> writes:
>>
>> > On 11/17, Stefan Beller wrote:
>> >> On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams <bmwill@google.com> wrote:
>> >>
>> >> > sha1_array_clear(&commits);
>> >> > - die("Failed to push all needed submodules!");
>> >> > + die ("Failed to push all needed submodules!");
>> >>
>> >> huh? Is this a whitespace change?
>> >
>> > That's odd...I didn't mean to add that lone space.
>>
>> Is that the only glitch in this round? IOW, is the series OK to be
>> picked up as long as I treak this out while queuing?
>
> It looks that way. And I did fix this in my local series. Let me know
> if you would rather I resend the series. Otherwise I think it looks
> good.OK, queued with trivial fix for now.
Thanks.