Re: [PATCH v2 2/2] push: fix --dry-run to not push submodules

From: Brandon Williams <bmwill@google.com>
Date: Nov 22, 2016, 18:18 UTC
Message-ID: <20161122181839.GF149321@google.com>
In-Reply-To: <xmqqk2bvquk1.fsf@gitster.mtv.corp.google.com>

On 11/22, Junio C Hamano wrote:

Show 15 quoted lines

> Brandon Williams <bmwill@google.com> writes:
> 
> > On 11/17, Stefan Beller wrote:
> >> On Thu, Nov 17, 2016 at 10:46 AM, Brandon Williams <bmwill@google.com> wrote:
> >> 
> >> >                                 sha1_array_clear(&commits);
> >> > -                               die("Failed to push all needed submodules!");
> >> > +                               die ("Failed to push all needed submodules!");
> >> 
> >> huh? Is this a whitespace change?
> >
> > That's odd...I didn't mean to add that lone space.
> 
> Is that the only glitch in this round?  IOW, is the series OK to be
> picked up as long as I treak this out while queuing?

It looks that way. And I did fix this in my local series. Let me know if you would rather I resend the series. Otherwise I think it looks good.

I do also have a follow on series I'm planning on sending out later to actually add in a feature which mimics what this bug does (as this functionality could be desirable in some circumstances) but thought it best to wait till heiko's and this series were more stable.

-- 
Brandon Williams