Re: [PATCH v2 12/16] pathspec: create parse_long_magic function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 10, 2016, 18:18 UTC
- Message-ID
- <xmqqk2b7ps08.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGZ79ka0P0rKF8QH3V0jC-O19eT0oaE+fJLGifbfmm3jC_SijA@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 5 quoted lines
> Jonathan Nieder mentioned off list that he prefers to see that > series rerolled without mutexes if possible. That is possible by > creating the questions "struct attr_check" before preloading the > index and then using the read only questions in the threaded code, > to obtain answers fast; also no need for a mutex.
I do not see how it would work without further splitting the attr_stack. I think you made it per check[], but you would further split it per <check, thread> before losing the mutex, no?