Re: [PATCH 09/17] pathspec: always show mnemonic and name in unsupported_magic

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 7, 2016, 10:44 UTC
Message-ID: <CACsJy8CKY5wb+0KzpincHLiYwC0za9Wexo9QvNedcQTGc+ZRDw@mail.gmail.com>
In-Reply-To: <1481061106-117775-10-git-send-email-bmwill@google.com>

On Wed, Dec 7, 2016 at 4:51 AM, Brandon Williams <bmwill@google.com> wrote:

Show 11 quoted lines

> @@ -413,10 +411,9 @@ void parse_pathspec(struct pathspec *pathspec,
>         prefixlen = prefix ? strlen(prefix) : 0;
>
>         for (i = 0; i < n; i++) {
> -               unsigned short_magic;
>                 entry = argv[i];
>
> -               item[i].magic = prefix_pathspec(item + i, &short_magic,
> +               item[i].magic = prefix_pathspec(item + i,
>                                                 flags,
>                                                 prefix, prefixlen, entry);

The final output looks a bit ...um.. strangely tall, with the first two lines that have one argument each, then the last line comes with three arguments. Maybe put 'flags' in the same line as 'item + i'?

>                 if ((flags & PATHSPEC_LITERAL_PATH) &&
>

-- 
Duy