Re: [PATCH v2 12/16] pathspec: create parse_long_magic function

From: Stefan Beller <sbeller@google.com>
Date: Dec 12, 2016, 05:38 UTC
Message-ID: <CAGZ79kbbk4vdW_mbC0riXOf=31V9AQV7zKEh56G+sxjjzAr2-g@mail.gmail.com>
In-Reply-To: <xmqqk2b7ps08.fsf@gitster.mtv.corp.google.com>

On Sat, Dec 10, 2016 at 10:18 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> Jonathan Nieder mentioned off list that he prefers to see that
>> series rerolled without mutexes if possible. That is possible by
>> creating the questions "struct attr_check" before preloading the
>> index and then using the read only questions in the threaded code,
>> to obtain answers fast; also no need for a mutex.
>
> I do not see how it would work without further splitting the
> attr_stack.  I think you made it per check[], but you would further
> split it per <check, thread> before losing the mutex, no?

Well I have not yet looked into it again, so my memories are rusty, but the <check> is read only, such that the answers only need to be per thread?