Re: [PATCH v4 5/7] builtin/grep.c: add '--column' option to 'git-grep(1)'
Taylor Blau <me@ttaylorr.com> writes:
Show 20 quoted lines
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index 18b494731f..5409a24399 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -13,7 +13,7 @@ SYNOPSIS
> [-v | --invert-match] [-h|-H] [--full-name]
> [-E | --extended-regexp] [-G | --basic-regexp]
> [-P | --perl-regexp]
> - [-F | --fixed-strings] [-n | --line-number]
> + [-F | --fixed-strings] [-n | --line-number] [--column]
> [-l | --files-with-matches] [-L | --files-without-match]
> [(-O | --open-files-in-pager) [<pager>]]
> [-z | --null]
> @@ -169,6 +169,9 @@ providing this option will cause it to die.
> --line-number::
> Prefix the line number to matching lines.
>
> +--column::
> + Prefix the 1-indexed column number of the first match on non-context lines.
> +
Two questions.
- It is fine that the leftmost column is 1, but what does this
number count? The number of bytes on the same line before the
first byte of the hit (plus 1)? The display width of the initial
non-matching part of the line (plus 1) on a fixed-width terminal?
The number of "characters"? Something else?
- Does --column combined with -v make any sense? If not, shouldn't
the command error out when both are given at the same time?
Junio C Hamano <gitster@pobox.com>