git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 22, 2018, 21:42 UTC
Message-ID
<87a7tuex47.fsf@evledraar.gmail.com>
In-Reply-To
<47f06ae36ce6af48fca06b140bdb5af2582116e1.1524429778.git.me@ttaylorr.com>
On Sun, Apr 22 2018, Taylor Blau wrote:

I think [345]/6 would make much more sense as just one patch. Comments on them to follow...

> In preparation of adding --column-number to 'git-grep(1)', we extend
> grep_opt to take in the requisite new members.

Just a nit: Makes sense to refer to these camel-cased in docs & commit messages.

> diff --git a/grep.c b/grep.c
> [...]
All of the boilerplate looks fine.
Previous: Taylor BlauNext: Taylor Blau
Message 18 of 108 in “grep.c: take regmatch_t as argument in match_line()”
  1. 1/6 grep.c: take regmatch_t as argument in match_line()Taylor Blau, Apr 21, 2018
  2. 0/6 Teach '--column-number' to 'git-grep(1)'Taylor Blau, Apr 22, 2018
  3. 1/6 grep.c: take regmatch_t as argument in match_line()Taylor Blau, Apr 22, 2018
  4. Eric SunshineApr 22, 2018
  5. Taylor BlauApr 22, 2018
  6. 2/6 grep.c: take column number as argument to show_line()Taylor Blau, Apr 22, 2018
  7. Eric SunshineApr 23, 2018
  8. Taylor BlauApr 23, 2018
  9. Eric SunshineApr 23, 2018
  10. Ævar Arnfjörð BjarmasonApr 23, 2018
  11. Eric SunshineApr 23, 2018
  12. Taylor BlauApr 24, 2018
  13. Ævar Arnfjörð BjarmasonApr 23, 2018
  14. Taylor BlauApr 24, 2018
  15. Junio C HamanoApr 24, 2018
  16. Taylor BlauApr 24, 2018
  17. 3/6 grep.[ch]: teach columnnum, color_columnno to grep_optTaylor Blau, Apr 22, 2018
  18. Ævar Arnfjörð BjarmasonApr 22, 2018
  19. Taylor BlauApr 22, 2018
  20. Eric SunshineApr 23, 2018
  21. Taylor BlauApr 23, 2018
  22. 4/6 grep.c: display column number of first matchTaylor Blau, Apr 22, 2018
  23. Eric SunshineApr 23, 2018
  24. Taylor BlauApr 23, 2018
  25. 5/6 builtin/grep.c: show column numbers via --column-numberTaylor Blau, Apr 22, 2018
  26. Ævar Arnfjörð BjarmasonApr 22, 2018
  27. Taylor BlauApr 22, 2018
  28. Eric SunshineApr 23, 2018
  29. Taylor BlauApr 23, 2018
  30. 6/6 contrib/git-jump/git-jump: use column number when grep-ingTaylor Blau, Apr 22, 2018
  31. Ævar Arnfjörð BjarmasonApr 22, 2018
  32. Taylor BlauApr 22, 2018
  33. Junio C HamanoApr 22, 2018
  34. Taylor BlauApr 22, 2018
  35. Junio C HamanoApr 23, 2018
  36. 0/7 Teach '--column-number' to 'git-grep(1)'Taylor Blau, Apr 24, 2018
  37. 1/7 Documentation/config.txt: camel-case lineNumber for consistencyTaylor Blau, Apr 24, 2018
  38. 2/7 grep.c: expose matched column in match_line()Taylor Blau, Apr 24, 2018
  39. 4/7 grep.c: display column number of first matchTaylor Blau, Apr 24, 2018
  40. Eric SunshineApr 24, 2018
  41. 6/7 grep.c: add configuration variables to show matched optionTaylor Blau, Apr 24, 2018
  42. 7/7 contrib/git-jump/git-jump: jump to match column in addition to lineTaylor Blau, Apr 24, 2018
  43. Eric SunshineApr 24, 2018
  44. Taylor BlauApr 24, 2018
  45. 5/7 builtin/grep.c: add '--column-number' option to 'git-grep(1)'Taylor Blau, Apr 24, 2018
  46. 3/7 grep.[ch]: extend grep_opt to allow showing matched columnTaylor Blau, Apr 24, 2018
  47. 0/7 Teach '--column' to 'git-grep(1)'Taylor Blau, May 5, 2018
  48. 1/7 Documentation/config.txt: camel-case lineNumber for consistencyTaylor Blau, May 5, 2018
  49. 2/7 grep.c: expose matched column in match_line()Taylor Blau, May 5, 2018
  50. René ScharfeMay 8, 2018
  51. 3/7 grep.[ch]: extend grep_opt to allow showing matched columnTaylor Blau, May 5, 2018
  52. 4/7 grep.c: display column number of first matchTaylor Blau, May 5, 2018
  53. 5/7 builtin/grep.c: add '--column' option to 'git-grep(1)'Taylor Blau, May 5, 2018
  54. Duy NguyenMay 5, 2018
  55. Taylor BlauMay 7, 2018
  56. Phillip WoodMay 6, 2018
  57. Ævar Arnfjörð BjarmasonMay 6, 2018
  58. Taylor BlauMay 7, 2018
  59. Junio C HamanoMay 7, 2018
  60. Taylor BlauMay 8, 2018
  61. 6/7 grep.c: add configuration variables to show matched optionTaylor Blau, May 5, 2018
  62. 7/7 contrib/git-jump/git-jump: jump to match column in addition to lineTaylor Blau, May 5, 2018
  63. Martin ÅgrenMay 6, 2018
  64. Ævar Arnfjörð BjarmasonMay 6, 2018
  65. Taylor BlauMay 7, 2018
  66. 0/7 Teach '--column' to 'git-grep(1)'Taylor Blau, May 9, 2018
  67. 1/7 Documentation/config.txt: camel-case lineNumber for consistencyTaylor Blau, May 9, 2018
  68. 3/7 grep.[ch]: extend grep_opt to allow showing matched columnTaylor Blau, May 9, 2018
  69. 4/7 grep.c: display column number of first matchTaylor Blau, May 9, 2018
  70. 6/7 grep.c: add configuration variables to show matched optionTaylor Blau, May 9, 2018
  71. 7/7 contrib/git-jump/git-jump: jump to match column in addition to lineTaylor Blau, May 9, 2018
  72. 5/7 builtin/grep.c: add '--column' option to 'git-grep(1)'Taylor Blau, May 9, 2018
  73. Phillip WoodMay 9, 2018
  74. Martin ÅgrenMay 9, 2018
  75. Taylor BlauMay 9, 2018
  76. Junio C HamanoMay 10, 2018
  77. René ScharfeMay 10, 2018
  78. Junio C HamanoMay 10, 2018
  79. Taylor BlauMay 12, 2018
  80. Junio C HamanoMay 12, 2018
  81. Taylor BlauMay 12, 2018
  82. Junio C HamanoMay 12, 2018
  83. Taylor BlauMay 18, 2018
  84. Junio C HamanoMay 18, 2018
  85. Taylor BlauMay 18, 2018
  86. Taylor BlauMay 19, 2018
  87. Taylor BlauMay 9, 2018
  88. Duy NguyenMay 9, 2018
  89. Taylor BlauMay 9, 2018
  90. 2/7 grep.c: expose matched column in match_line()Taylor Blau, May 9, 2018
  91. 0/7 Teach '--column' to 'git-grep(1)'Taylor Blau, May 12, 2018
  92. 1/7 Documentation/config.txt: camel-case lineNumber for consistencyTaylor Blau, May 12, 2018
  93. 2/7 grep.c: expose matched column in match_line()Taylor Blau, May 12, 2018
  94. 3/7 grep.[ch]: extend grep_opt to allow showing matched columnTaylor Blau, May 12, 2018
  95. 4/7 grep.c: display column number of first matchTaylor Blau, May 12, 2018
  96. 5/7 builtin/grep.c: add '--column' option to 'git-grep(1)'Taylor Blau, May 12, 2018
  97. 6/7 grep.c: add configuration variables to show matched optionTaylor Blau, May 12, 2018
  98. 7/7 contrib/git-jump/git-jump: jump to match column in addition to lineTaylor Blau, May 12, 2018
  99. 2/6 grep.c: take column number as argument to show_line()Taylor Blau, Apr 21, 2018
  100. 3/6 grep.[ch]: teach columnnum, color_columnno to grep_optTaylor Blau, Apr 21, 2018
  101. Martin ÅgrenApr 21, 2018
  102. 4/6 grep.c: display column number of first matchTaylor Blau, Apr 21, 2018
  103. 5/6 builtin/grep.c: show column numbers via --column-numberTaylor Blau, Apr 21, 2018
  104. Junio C HamanoApr 21, 2018
  105. Junio C HamanoApr 21, 2018
  106. René ScharfeApr 21, 2018
  107. Martin ÅgrenApr 21, 2018
  108. 6/6 contrib/git-jump/git-jump: use column number when grep-ingTaylor Blau, Apr 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.