Re: [PATCH v2 3/6] grep.[ch]: teach columnnum, color_columnno to grep_opt

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 23, 2018, 00:21 UTC
Message-ID: <CAPig+cQXsU4cXLtZPA-C84DH+PzrgN7C8_A-NZE+6e5HoJEFCA@mail.gmail.com>
In-Reply-To: <20180422232447.GA48072@syl.local>

On Sun, Apr 22, 2018 at 7:24 PM, Taylor Blau <me@ttaylorr.com> wrote:

Show 10 quoted lines

> On Sun, Apr 22, 2018 at 11:42:48PM +0200, Ęvar Arnfjörš Bjarmason wrote:
>> On Sun, Apr 22 2018, Taylor Blau wrote:
>> > In preparation of adding --column-number to 'git-grep(1)', we extend
>> > grep_opt to take in the requisite new members.
>>
>> Just a nit: Makes sense to refer to these camel-cased in docs & commit
>> messages.
>
> Could you clarify which? I am not sure if you mean --column-number,
> 'git-grep(1)', or grep_opt.

I think Ævar was referring to this bit from the commit message (which unfortunately got snipped in his review):

    We additionally teach the 'grep.columnnumber' and
    'color.grep.columnnumber' configuration variables to configure
    showing and coloring the column number, respectively. (These
    options remain undocumented until 'git-grep(1)' learns the
    --column option in a forthcoming commit.)

He was suggesting camel-casing 'grep.columnNumber' and 'color.grep.columNumber' even in the commit message.