Re: [PATCH v2 6/6] contrib/git-jump/git-jump: use column number when grep-ing

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 22, 2018, 21:49 UTC
Message-ID: <877eoyewss.fsf@evledraar.gmail.com>
In-Reply-To: <b9d2578d8dc644e68a09445e14156d789bfe395b.1524429778.git.me@ttaylorr.com>

On Sun, Apr 22 2018, Taylor Blau wrote:

Show 17 quoted lines

> This patch adds the '--column-number' synonym '-m' to the default
> grep command so that callers are brought to the correct line _and_
> column of each matched location.
> [...]
> diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
> index 80ab0590bc..2706963690 100755
> --- a/contrib/git-jump/git-jump
> +++ b/contrib/git-jump/git-jump
> @@ -52,7 +52,7 @@ mode_merge() {
>  # editor shows them to us in the status bar.
>  mode_grep() {
>  	cmd=$(git config jump.grepCmd)
> -	test -n "$cmd" || cmd="git grep -n"
> +	test -n "$cmd" || cmd="git grep -n -m"
>  	$cmd "$@" |
>  	perl -pe '
>  	s/[ \t]+/ /g;

So this re-roll doesn't have the alias -m anymore, but this makes use of it. Seems you just forgot to update this from v1, unless I'm missing something while skimming this...