git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] ci/install-depends: attempt to fix "brew cask" stuff

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 15, 2021, 03:14 UTC
Message-ID
<xmqqk0sevqlh.fsf@gitster.c.googlers.com>
It seems that homebrew suddenly started giving us trouble, like this:
https://github.com/git/git/runs/1705953982?check_suite_focus=true#step:3:70

Here is my attempt to work it around by blindly following the suggested course of action in the error message, without knowing what I am doing X-<. I am not a Mac person.

What is frustrating is that every time we hit a minor snag like this to break one of the jobs, all other unrelated jobs are also taken down.

Help by those who know what they are doing on macOS would greatly be appreciated. Thanks.

----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- >8 ----- We run "git pull" against "$cask_repo"; clarify that we are expecting not to have any of our own modifications and running "git pull" to merely update, by passing "--ff-only" on the command line.

Also, the "brew cask install" command line triggers an error message that says:

    Error: Calling brew cask install is disabled! Use brew install
    [--cask] instead.

In addition, "brew install caskroom/cask/perforce" step triggers an error that says:

    Error: caskroom/cask was moved. Tap homebrew/cask instead.

Attempt to see if blindly following the suggestion in these error messages gets us into a better shape.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ci/install-dependencies.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 0229a77f7d..0b1184e04a 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -44,13 +44,13 @@ osx-clang|osx-gcc)
 	test -z "$BREW_INSTALL_PACKAGES" ||
 	brew install $BREW_INSTALL_PACKAGES
 	brew link --force gettext
-	brew cask install --no-quarantine perforce || {
+	brew install --cask --no-quarantine perforce || {
 		# Update the definitions and try again
 		cask_repo="$(brew --repository)"/Library/Taps/homebrew/homebrew-cask &&
-		git -C "$cask_repo" pull --no-stat &&
-		brew cask install --no-quarantine perforce
+		git -C "$cask_repo" pull --no-stat --ff-only &&
+		brew install --cask --no-quarantine perforce
 	} ||
-	brew install caskroom/cask/perforce
+	brew install homebrew/cask/perforce
 	case "$jobname" in
 	osx-gcc)
 		brew install gcc@9
-- 
2.30.0-386-gfb533afdb4
Next: Junio C Hamano
Message 1 of 14 in “ci/install-depends: attempt to fix "brew cask" stuff”
  1. ci/install-depends: attempt to fix "brew cask" stuffJunio C Hamano, Jan 15, 2021
  2. Junio C HamanoJan 15, 2021
  3. Eric SunshineJan 15, 2021
  4. Derrick StoleeJan 15, 2021
  5. Junio C HamanoJan 15, 2021
  6. Jeff KingJan 15, 2021
  7. Eric SunshineJan 15, 2021
  8. Jeff KingJan 15, 2021
  9. SZEDER GáborFeb 1, 2021
  10. Philippe BlainJan 24, 2021
  11. Junio C HamanoJan 24, 2021
  12. Taylor BlauJan 25, 2021
  13. Jeff KingJan 27, 2021
  14. Junio C HamanoJan 28, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.