Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 15, 2021, 06:05 UTC
- Message-ID
- <CAPig+cTSbwURNUEoUk8UCtVM69NuWg545zavJkyCYw8T6aG1SQ@mail.gmail.com>
- In-Reply-To
- <xmqqa6tavjgm.fsf@gitster.c.googlers.com>
On Fri, Jan 15, 2021 at 12:50 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > It seems that homebrew suddenly started giving us trouble, like this: > > https://github.com/git/git/runs/1705953982?check_suite_focus=true#step:3:70 > > > After seeing 'seen' with this patch at its tip pass the tests [*1*], > I prepared a merge of this change into the tip of 'next' and > tentatively updated 'seen' with it. > > The test is still running [*2*], but the problematic part in the > macOS build has already passed, so I am planning to fast-track this > change down to 'next', 'master' and eventually down to 'maint' to > keep the CI going to help other platforms catch more interesting > problems. > > Help from those who are more familiar with macOS and homebrew is > still appreciated, though.
I looked over your Homebrew-related changes, and they seem fine.
The `brew install homebrew/cask/perforce` command could be shortened to `brew install perforce`, at least at the present, but being explicit with the long identifier is probably better anyhow.