Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2021, 06:18 UTC
Message-ID: <xmqqeeia26ze.fsf@gitster.c.googlers.com>
In-Reply-To: <830a88ce-1728-a6a5-f60d-59328f85932c@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 8 quoted lines

> Yes, a quick Google search pointed me to a blog post [1]
> that mentions using 'fail-fast: false' in the test matrix so that
> one failing job does not automatically cancel the rest of the jobs
> in the matrix (the default is 'true') [2].
>
> If we apply that to all four matrices in the workflow file,
> (windows-test, vs-test, regular and dockerized), it would be
> something like this:

I am assuming that "failure of build stops tests from running", which is done on the windows/vs-build side, is still kept with this change. If that is the case, it sounds quite sensible.

> I've CC-ed Dscho regarding if we also want this for the Windows tests,
> (I don't see why not) and if we feel it's a good idea I can
> send a proper patch.

I often see windows/vs-test #4 fail first and take other 9 with it. We may see some interesting patterns to emerge, when we run all of them (and let all of them fail X-<).

Thanks for working on this.