Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff
- From
Jeff King <peff@peff.net>
- Date
- Jan 15, 2021, 19:59 UTC
- Message-ID
- <YAH0G+Y4fIxoTeZa@coredump.intra.peff.net>
- In-Reply-To
- <xmqqk0sevqlh.fsf@gitster.c.googlers.com>
On Thu, Jan 14, 2021 at 07:14:34PM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> It seems that homebrew suddenly started giving us trouble, like this: > > https://github.com/git/git/runs/1705953982?check_suite_focus=true#step:3:70 > > Here is my attempt to work it around by blindly following the > suggested course of action in the error message, without knowing > what I am doing X-<. I am not a Mac person. > > What is frustrating is that every time we hit a minor snag like this > to break one of the jobs, all other unrelated jobs are also taken > down.
I think that has to do with the grouping in the workflow file (the Windows builds, for example, will cancel the _other_ Windows tests if they fail, but not the Linux ones).
So we could split the macos test out. It would probably involve duplicating a little bit of the content, but we do something similar for the dockerized builds. It might be that there is an option we can set to say "keep building the others even if one of these fails", which would give us the best of both.
> brew install $BREW_INSTALL_PACKAGES
> brew link --force gettext
> - brew cask install --no-quarantine perforce || {
> + brew install --cask --no-quarantine perforce || {On a related note, it feels like perforce is a frequent offender for triggering spurious failures (both for homebrew setup, but I have definitely seen racy/flaky failures from it as well). I am tempted to say it is not worth the trouble, but then I do not care at all about git-p4 myself in the first place, so I may be biased.
-Peff