Re: [PATCH v2 3/4] sideband: append suffix for message whose CR in next pktline

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2021, 01:17 UTC
Message-ID: <xmqqk0mwylhc.fsf@gitster.g>
In-Reply-To: <CANYiYbGtfgZepnfTWGjbmOh2bxa8tZ7bvgtVTo6qTQpCP9MPag@mail.gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 8 quoted lines

>     /*
>      * Let's insert a suffix to clear the end
>      * of the screen line, but only if current
>      * line data actually contains something.
>      */
>
> So my implementation is to try not to break the original
> implementation, and keep the linelen unchanged.

I knew what you wanted to do from your code---I am questioning if that "only when something is there" was really sensible, or if it was just attracting bugs.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.