Re: [PATCH v2 0/4] Fixed t6020 bash compatible issue and fixed wrong sideband suffix issue

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jun 15, 2021, 03:11 UTC
Message-ID: <CANYiYbHA+obZPPNw3Oc0h5BbtdVyqpxOK-u3dxDB-sQbdcY0yQ@mail.gmail.com>
In-Reply-To: <xmqqa6ntytks.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年6月14日周一 下午12:10写道：

Show 15 quoted lines

>
> Jiang Xin <worldhello.net@gmail.com> writes:
>
> > From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
> >
> > In addition to fix the bash incompatible issue of t6020, find another
> > issue when try to rewrite t5411 to compare raw command output.
>
> Do the three later patches depend on the t6020 fix, or is this made
> a 4-patch series only for the convenience of sending them out?
>
> It's not like get_abbrev_oid() used in t6020 is defined in a common
> part of the test library and later used by other tests (instead, the
> patches duplicate this helper function into yet two more files).
>

Will split it into two patch series. One will fix bash incompatible parameter expansion in t6020, another will fix clear-to-eol at packet boundary issue of sideband and try to test raw output in t6020, t5548 and t5411.

I also queue another patch series, which add "--bare" support to "test_create_repo", and replace "git init" command in test cases to adapt to variable GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME.

-- Jiang Xin