Re: [PATCH v2 3/4] sideband: append suffix for message whose CR in next pktline

From: Nicolas Pitre <nico@fluxnic.net>
Date: Jun 15, 2021, 02:11 UTC
Message-ID: <0pqq6s9-n238-95ss-nsqr-42o75sr933r@syhkavp.arg>
In-Reply-To: <CANYiYbG6bKwheThWz2ecHUTh7JFmTsi-F9FtYkcoS0az=f=m6Q@mail.gmail.com>

On Tue, 15 Jun 2021, Jiang Xin wrote:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> 于2021年6月15日周二 上午9:17写道：
> >
> > Jiang Xin <worldhello.net@gmail.com> writes:
> >
> > >     /*
> > >      * Let's insert a suffix to clear the end
> > >      * of the screen line, but only if current
> > >      * line data actually contains something.
> > >      */
> > >
> > > So my implementation is to try not to break the original
> > > implementation, and keep the linelen unchanged.
> >
> > I knew what you wanted to do from your code---I am questioning if
> > that "only when something is there" was really sensible, or if it
> > was just attracting bugs.
> >
> 
> @Nicolas, what's your opinion? Is it ok to add clear-to-eol suffix to
> each line even empty ones?

That would be the simplest thing to do.

But there must have been a reason for doing it otherwise. I just don't remember anymore.

Maybe it had to do with progress reporting that does a bunch of percentage updates followed by '\r' to remain on the same line, and at the end a single '\n' to move to the next line without erasing the final status report line. That would be a case for not clearing empty lines.

Nicolas