Re: [PATCH v2 3/4] sideband: append suffix for message whose CR in next pktline

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jun 15, 2021, 01:47 UTC
Message-ID: <CANYiYbG6bKwheThWz2ecHUTh7JFmTsi-F9FtYkcoS0az=f=m6Q@mail.gmail.com>
In-Reply-To: <xmqqk0mwylhc.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年6月15日周二 上午9:17写道：

Show 16 quoted lines

>
> Jiang Xin <worldhello.net@gmail.com> writes:
>
> >     /*
> >      * Let's insert a suffix to clear the end
> >      * of the screen line, but only if current
> >      * line data actually contains something.
> >      */
> >
> > So my implementation is to try not to break the original
> > implementation, and keep the linelen unchanged.
>
> I knew what you wanted to do from your code---I am questioning if
> that "only when something is there" was really sensible, or if it
> was just attracting bugs.
>

@Nicolas, what's your opinion? Is it ok to add clear-to-eol suffix to each line even empty ones?

-- Jiang Xin