Re: [PATCH 3/5] trailer: add tests to check defaulting behavior with --no-* flags

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2023, 01:13 UTC
Message-ID: <xmqqjzu7irhw.fsf@gitster.g>
In-Reply-To: <6b427b4b1e82b1f01640f1f49fe8d1c2fd02111e.1691210737.git.gitgitgadget@gmail.com>

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> @@ -114,8 +114,10 @@ OPTIONS
>  	Specify where all new trailers will be added.  A setting
>  	provided with '--where' overrides all configuration variables

Obviously this is not a new issue, but "all configuration variables" is misleading (the same comment applies to the description of the "--[no-]if-exists" and the "--[no-]if-missing" options).

If I am reading the code correctly, --where=value overrides the trailer.where variable and nothing else, and --no-where stops the overriding of the trailer.where variable. Ditto for the other two with their relevant configuration variables.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.