Re: [PATCH 1/5] trailer tests: make test cases self-contained

From: Linus Arver <linusa@google.com>
Date: Aug 7, 2023, 05:50 UTC
Message-ID: <owlya5v3bdu5.fsf@fine.c.googlers.com>
In-Reply-To: <6d67ae6b1f62a2be076d752a2af65bb07998ca73.1691210737.git.gitgitgadget@gmail.com>

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 13 quoted lines

> From: Linus Arver <linusa@google.com>
> ...
> @@ -1392,7 +1610,9 @@ test_expect_success 'with failing command using $ARG' '
>  '
>  
>  test_expect_success 'with empty tokens' '
> -	git config --unset trailer.fix.command &&
> +	test_config trailer.sign.command "echo \"\$GIT_AUTHOR_NAME <\$GIT_AUTHOR_EMAIL>\"" &&
> +	test_config trailer.sign.key "Signed-off-by: " &&
> +	test_config trailer.ifexists "addIfDifferent" &&
>  	cat >expected <<-EOF &&
>  
>  		Signed-off-by: A U Thor <author@example.com>

In this test and some other places we get the chance to remove invocations of "git config --unset ..." (because we don't leak config state anymore). I will update the commit message accordingly in the next reroll.