Re: [PATCH v3 05/13] trailer: trailer location is a place, not an action
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 30 quoted lines
> From: Linus Arver <linusa@google.com>
>
> Fix the help text to say "placement" instead of "action" because the
> values are placements, not actions.
>
> While we're at it, tweak the documentation to say "placements" instead
> of "values", similar to how the existing language for "--if-exists" uses
> the word "action" to describe both the syntax (with the phrase
> "--if-exists <action>") and the possible values (with the phrase
> "possible actions").
>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
> Documentation/git-interpret-trailers.txt | 2 +-
> builtin/interpret-trailers.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt
> index 72f5bdb652f..b5284c3d33f 100644
> --- a/Documentation/git-interpret-trailers.txt
> +++ b/Documentation/git-interpret-trailers.txt
> @@ -117,7 +117,7 @@ OPTIONS
> and applies to all '--trailer' options until the next occurrence of
> '--where' or '--no-where'. Upon encountering '--no-where', clear the
> effect of any previous use of '--where', such that the relevant configuration
> - variables are no longer overridden. Possible values are `after`,
> + variables are no longer overridden. Possible placements are `after`,
> `before`, `end` or `start`.
>
> --if-exists <action>::
Not shown in the diff as printed in this email, but this option is
indeed documented with "<placement>". Up to and including this patch
makes sense.