Re: [PATCH 3/5] trailer: add tests to check defaulting behavior with --no-* flags

From: Linus Arver <linusa@google.com>
Date: Aug 7, 2023, 06:35 UTC
Message-ID: <owly7cq7bbr9.fsf@fine.c.googlers.com>
In-Reply-To: <owlyfs4vbeus.fsf@fine.c.googlers.com>

Linus Arver <linusa@google.com> writes:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>>> @@ -114,8 +114,10 @@ OPTIONS
>>>  	Specify where all new trailers will be added.  A setting
>>>  	provided with '--where' overrides all configuration variables
>>
>> Obviously this is not a new issue, but "all configuration variables"
>> is misleading (the same comment applies to the description of the
>> "--[no-]if-exists" and the "--[no-]if-missing" options).
>
> Agreed.
>
>> If I am reading the code correctly, --where=value overrides the
>> trailer.where variable and nothing else, and --no-where stops the
>> overriding of the trailer.where variable.  Ditto for the other two
>> with their relevant configuration variables.
>
> That is also my understanding. Will update to remove the "all" wording.

Hmph, actually it also overrides any applicable "trailer.<token>.where" configurations (these <token>-specific configurations override the "trailer.where" configuration where applicable). Still, the "all configuration variables" wording should be updated, probably like this:

    ›  Specify where all new trailers will be added.  A setting
    ›  provided with '--where' overrides the `trailer.where` and any
    ›  applicable `trailer.<token>.where` configuration variables
    ›  and applies to all '--trailer' options until the next occurrence of
    ›  '--where' or '--no-where'.