git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] doc: merge-tree: use || directly

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 8, 2024, 20:44 UTC
Message-ID
<xmqqjzeiz5ne.fsf@gitster.g>
In-Reply-To
<13e0f3bed5dd894ee692c672b301697e0a909e04.1728413450.git.code@khaugsbakk.name>
Kristoffer Haugsbakk <code@khaugsbakk.name> writes:
Show 6 quoted lines
> -       NEWTREE=$(git merge-tree --write-tree $BRANCH1 $BRANCH2)
> -       test $? -eq 0 || die "There were conflicts..."
> +       NEWTREE=$(git merge-tree --write-tree $BRANCH1 $BRANCH2) || {
> +           echo "There were conflicts..." 1>&2
> +           exit 1
> +       }

Makes sense. Was there a particular reason why these two patches had to be done in two separate steps?

Looking good otherwise.  Thanks.
Previous: Kristoffer HaugsbakkNext: Kristoffer Haugsbakk
Message 22 of 27 in “doc: merge-tree: improve the script example”
  1. 0/3 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 7, 2024
  2. 1/3 doc: merge-tree: provide a commit messageKristoffer Haugsbakk, Oct 7, 2024
  3. Kristoffer HaugsbakkOct 7, 2024
  4. Elijah NewrenOct 7, 2024
  5. Kristoffer HaugsbakkOct 7, 2024
  6. 2/3 doc: merge-tree: use lower-case variablesKristoffer Haugsbakk, Oct 7, 2024
  7. Phillip WoodOct 7, 2024
  8. Elijah NewrenOct 7, 2024
  9. 3/3 doc: merge-tree: use || directlyKristoffer Haugsbakk, Oct 7, 2024
  10. Elijah NewrenOct 7, 2024
  11. Kristoffer HaugsbakkOct 7, 2024
  12. Phillip WoodOct 7, 2024
  13. Kristoffer HaugsbakkOct 7, 2024
  14. 0/2 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 8, 2024
  15. 1/2 doc: merge-tree: provide a commit messageKristoffer Haugsbakk, Oct 8, 2024
  16. Junio C HamanoOct 8, 2024
  17. Kristoffer HaugsbakkOct 8, 2024
  18. Kristoffer HaugsbakkOct 9, 2024
  19. Junio C HamanoOct 9, 2024
  20. Andreas SchwabOct 9, 2024
  21. 2/2 doc: merge-tree: use || directlyKristoffer Haugsbakk, Oct 8, 2024
  22. Junio C HamanoOct 8, 2024
  23. Kristoffer HaugsbakkOct 8, 2024
  24. 0/1 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 9, 2024
  25. 1/1 doc: merge-tree: improve example scriptKristoffer Haugsbakk, Oct 9, 2024
  26. Elijah NewrenOct 9, 2024
  27. Junio C HamanoOct 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.