Re: [PATCH 1/3] doc: merge-tree: provide a commit message
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Oct 7, 2024, 12:02 UTC
- Message-ID
- <b41ce281-d3b8-43c3-8b27-f5dc59601ca7@app.fastmail.com>
- In-Reply-To
- <fef203471f4492af1468a0c91088324c394effd5.1728298931.git.code@khaugsbakk.name>
On Mon, Oct 7, 2024, at 13:10, Kristoffer Haugsbakk wrote:
> From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> > > From: Kristoffer Haugsbakk <code@khaugsbakk.name>
I think these got double upped since I used `--from` in format-patch. Then I used send-email. format-patch warns against that:
“ Note that this option is only useful if you are actually sending the
emails and want to identify yourself as the sender, but
retain the original author (and git am will correctly pick up
the in-body header). Note also that git send-email already
handles this transformation for you, and this option should
not be used if you are feeding the result to git send-email.So under the normal use I guess:
• You have someone else’s patches • send-email sees that you are not that person (because of your config) • It puts the From in the message body (it just works)
But that wasn’t the case for me since my ident is still the same as the author.
That went over my head before I sent.
-- Kristoffer Haugsbakk