Re: [PATCH 2/3] doc: merge-tree: use lower-case variables

From: Elijah Newren <newren@gmail.com>
Date: Oct 7, 2024, 15:22 UTC
Message-ID: <CABPp-BFogoe5+X8aTpLF8ksVbZJxwXOw-TCh6k5aAJctxUzZUw@mail.gmail.com>
In-Reply-To: <d18f6fdf-d0ba-40e1-a2b9-2fecfbdadde4@gmail.com>

On Mon, Oct 7, 2024 at 7:58 AM Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 13 quoted lines

>
> Hi Kristoffer
>
> On 07/10/2024 12:10, Kristoffer Haugsbakk wrote:
> > From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
> >
> > From: Kristoffer Haugsbakk <code@khaugsbakk.name>
> >
> > This is easier to read.
>
> I think that is a matter of taste, one could argue that using uppercase
> variable names makes them stand out so the user can see which arguments
> are parameters more clearly.

Yeah, I wrote it as uppercase because I thought that was easier to read for the reasons Phillip gives. It's not a strong preference, but I do think the commit message needs a more detailed rationale or link to an agreed project coding style or something, otherwise the commit message may appear to be false to half the readers.