git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/1] doc: merge-tree: improve example script

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
Oct 9, 2024, 16:53 UTC
Message-ID
<c7e0d76e71eef56c6279e0f7e82a2d194f78d2a4.1728492617.git.code@khaugsbakk.name>
In-Reply-To
<cover.1728492617.git.code@khaugsbakk.name>
• Provide a commit message in the example command.
  The command will hang since it is waiting for a commit message on
  stdin.  Which is usable but not straightforward enough since this is
  example code.
• Use `||` directly since that is more straightforward than checking the
  last exit status.
  Also use `echo` and `exit` since `die` is not defined.
• Expose variable declarations.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
 Documentation/git-merge-tree.txt | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-merge-tree.txt b/Documentation/git-merge-tree.txt
index 84cb2edf6d0..0b6a8a19b1f 100644
--- a/Documentation/git-merge-tree.txt
+++ b/Documentation/git-merge-tree.txt
@@ -211,9 +211,15 @@ linkgit:git-commit-tree[1], linkgit:git-write-tree[1],
 linkgit:git-update-ref[1], and linkgit:git-mktag[1].  Thus, it can be
 used as a part of a series of steps such as:
 
-       NEWTREE=$(git merge-tree --write-tree $BRANCH1 $BRANCH2)
-       test $? -eq 0 || die "There were conflicts..."
-       NEWCOMMIT=$(git commit-tree $NEWTREE -p $BRANCH1 -p $BRANCH2)
+       vi message.txt
+       BRANCH1=refs/heads/test
+       BRANCH2=main
+       NEWTREE=$(git merge-tree --write-tree $BRANCH1 $BRANCH2) || {
+           echo "There were conflicts..." 1>&2
+           exit 1
+       }
+       NEWCOMMIT=$(git commit-tree $NEWTREE -F message.txt \
+           -p $BRANCH1 -p $BRANCH2)
        git update-ref $BRANCH1 $NEWCOMMIT
 
 Note that when the exit status is non-zero, `NEWTREE` in this sequence
-- 
2.46.1.641.g54e7913fcb6
Previous: Kristoffer HaugsbakkNext: Elijah Newren
Message 25 of 27 in “doc: merge-tree: improve the script example”
  1. 0/3 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 7, 2024
  2. 1/3 doc: merge-tree: provide a commit messageKristoffer Haugsbakk, Oct 7, 2024
  3. Kristoffer HaugsbakkOct 7, 2024
  4. Elijah NewrenOct 7, 2024
  5. Kristoffer HaugsbakkOct 7, 2024
  6. 2/3 doc: merge-tree: use lower-case variablesKristoffer Haugsbakk, Oct 7, 2024
  7. Phillip WoodOct 7, 2024
  8. Elijah NewrenOct 7, 2024
  9. 3/3 doc: merge-tree: use || directlyKristoffer Haugsbakk, Oct 7, 2024
  10. Elijah NewrenOct 7, 2024
  11. Kristoffer HaugsbakkOct 7, 2024
  12. Phillip WoodOct 7, 2024
  13. Kristoffer HaugsbakkOct 7, 2024
  14. 0/2 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 8, 2024
  15. 1/2 doc: merge-tree: provide a commit messageKristoffer Haugsbakk, Oct 8, 2024
  16. Junio C HamanoOct 8, 2024
  17. Kristoffer HaugsbakkOct 8, 2024
  18. Kristoffer HaugsbakkOct 9, 2024
  19. Junio C HamanoOct 9, 2024
  20. Andreas SchwabOct 9, 2024
  21. 2/2 doc: merge-tree: use || directlyKristoffer Haugsbakk, Oct 8, 2024
  22. Junio C HamanoOct 8, 2024
  23. Kristoffer HaugsbakkOct 8, 2024
  24. 0/1 doc: merge-tree: improve the script exampleKristoffer Haugsbakk, Oct 9, 2024
  25. 1/1 doc: merge-tree: improve example scriptKristoffer Haugsbakk, Oct 9, 2024
  26. Elijah NewrenOct 9, 2024
  27. Junio C HamanoOct 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.