git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH v2 1/2] Makefile: add check-headers target

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 8, 2014, 18:56 UTC
Message-ID
<xmqqiokylz46.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1410049821-49861-1-git-send-email-davvid@gmail.com>
David Aguilar <davvid@gmail.com> writes:
> +IFS='
> +'
> +git ls-files *.h ewah/*.h vcs-svn/*.h xdiff/*.h |

Hmm. This is only for true developers (not one who merely compiles after expanding a tarball), so "git ls-files" may probably be OK.

But "/bin/ls" would be equally fine for that, no? After all, you are letting your shell to expand the wildcard, and a developer would want to make sure his new header is kosher before running "git add" on it.

Previous: Jonathan NiederNext: Matthieu Moy
Message 9 of 14 in “Makefile: add check-headers target”
  1. 1/2 Makefile: add check-headers targetDavid Aguilar, Sep 7, 2014
  2. 2/2 headers: include dependent headersDavid Aguilar, Sep 7, 2014
  3. René ScharfeSep 7, 2014
  4. Jonathan NiederSep 7, 2014
  5. Johannes SixtSep 7, 2014
  6. Jonathan NiederSep 7, 2014
  7. David AguilarSep 7, 2014
  8. Jonathan NiederSep 7, 2014
  9. Junio C HamanoSep 8, 2014
  10. Matthieu MoySep 8, 2014
  11. Junio C HamanoSep 8, 2014
  12. David AguilarSep 10, 2014
  13. Junio C HamanoSep 10, 2014
  14. Matthieu MoySep 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.