Re: [RFC PATCH v2 1/2] Makefile: add check-headers target

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2014, 19:57 UTC
Message-ID: <xmqqa969nav9.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqsik13o84.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> David Aguilar <davvid@gmail.com> writes:
>>
>>> +IFS='
>>> +'
>>> +git ls-files *.h ewah/*.h vcs-svn/*.h xdiff/*.h |
>>
>> Hmm.  This is only for true developers (not one who merely compiles
>> after expanding a tarball), so "git ls-files" may probably be OK.
>>
>> But "/bin/ls" would be equally fine for that, no?
>
> Actually, since this is "| while read header", I have to wonder why this
> is not written as
>
> for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
> do
> 	...
> done

Yes, that would be even better. Then you wouldn't even have to worry about $IFS dance.