Re: [RFC PATCH v2 1/2] Makefile: add check-headers target

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 10, 2014, 17:24 UTC
Message-ID: <vpqk35bo0bh.fsf@anie.imag.fr>
In-Reply-To: <xmqq38bzieqj.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 24 quoted lines

> David Aguilar <davvid@gmail.com> writes:
>
>> On Mon, Sep 08, 2014 at 12:57:46PM -0700, Junio C Hamano wrote:
>>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>> ...
>>> > for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
>>> > do
>>> > 	...
>>> > done
>>> 
>>> Yes, that would be even better.  Then you wouldn't even have to
>>> worry about $IFS dance.
>>
>> The original motivation was to avoid picking up the generated
>> common-cmds.h header file.
>
> 	for header
>         do
>         	case "$header" in $exceptions) continue ;; esac
> 		...
> 	done
>
> with comments describing why these exceptions are made would be a
> better way to go in such a case.

+1 from me. It would allow developers to use the rule without "git add"-ing new .h files, and the comment would document why the exceptions are there (which missed in the original patch IMHO).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/