From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Sep 2014 18:56:57 GMT
Subject: Re: [RFC PATCH v2 1/2] Makefile: add check-headers target
Message-ID: <xmqqiokylz46.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1410049821-49861-1-git-send-email-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

> +IFS='
> +'
> +git ls-files *.h ewah/*.h vcs-svn/*.h xdiff/*.h |

Hmm.  This is only for true developers (not one who merely compiles
after expanding a tarball), so "git ls-files" may probably be OK.

But "/bin/ls" would be equally fine for that, no?  After all, you
are letting your shell to expand the wildcard, and a developer would
want to make sure his new header is kosher before running "git add"
on it.