Re: [RFC/PATCH 2/2] log: add "--no-show-signature" command line option

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2016, 17:22 UTC
Message-ID: <xmqqiny0wx8m.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160526163241.GC18210@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Thu, May 26, 2016 at 06:36:47PM +0530, Mehul Jain wrote:
>
>> If "log.showsignature=true", then there is no way to override it using
>> command line switch.
>> 
>> Teach "git log" and "git show" about "--no-show-signature" command line
>> option.
>
> I think this is teaching all of the revision machinery about it (which
> is a good thing).

I agree that the proposed commit log message should be updated to say so.

Because we do not want .showsignature configuration to affect rev-list nor format-patch, and we will not make "--show-sig" the default for them either. From that point of view, there is no reason for them to know about the "--no-show-signature" option.

The only reason why teaching the "--no-show-signature" option to these commands is a good idea is because it would help people who create an alias with "--show-sig" in early part of the command line, e.g.

	[alias] fp = format-patch --show-signature

by allowing them to countermand with --no-show-signature, i.e.

	$ git fp --no-show-signature ...

If we are updating the log message in the final submission of this patch, we'd want it to be clear that the presence of this option is not an excuse to introduce .showsignature that affects rev-list later to make sure we do not have to waste our time rejecting such a patch in the future.