Re: [RFC/PATCH 2/2] log: add "--no-show-signature" command line option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 27, 2016, 17:37 UTC
- Message-ID
- <xmqq4m9js8qb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CA+DCAeTnkTRnmscduio1-buKd2gNcaScYkLY7YfEQ+_Cm=Z28Q@mail.gmail.com>
Mehul Jain <mehul.jain2029@gmail.com> writes:
Show 17 quoted lines
> On Thu, May 26, 2016 at 10:52 PM, Junio C Hamano <gitster@pobox.com> wrote: > >> The only reason why teaching the "--no-show-signature" option to >> these commands is a good idea is because it would help people who >> create an alias with "--show-sig" in early part of the command line, >> e.g. >> >> [alias] fp = format-patch --show-signature >> >> by allowing them to countermand with --no-show-signature, i.e. >> >> $ git fp --no-show-signature ... >> ... > > Just out of curiosity, I was thinking that we might be able to teach > "--no-show-signature" option only to git-show, git-log, git-whatchanged > and git-reflog.
Yeah, I know it is possible with extra code, but I do not think of a good reason why it is necessary.