Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- May 27, 2016, 04:01 UTC
- Message-ID
- <CAFZEwPOajimmwh9DW=zbacqLYh1mREii8QGWTMiMQFg0TsdVQQ@mail.gmail.com>
- In-Reply-To
- <CA+DCAeSYr-q-0uSeDymJPHZwVZDZhh4yHH48peLOKodbxW1N7A@mail.gmail.com>
Hey Mehul,
On Thu, May 26, 2016 at 8:34 PM, Mehul Jain <mehul.jain2029@gmail.com> wrote:
Show 19 quoted lines
> Hi Remi, > > Thanks for your input. > > On Thu, May 26, 2016 at 7:12 PM, Remi Galan Alfonso > <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote: >> Hi Mehul, >> >> Mehul Jain <mehul.jain2029@gmail.com> writes: >>> +test_expect_success GPG '--show-signature overrides log.showsignature=false' ' >>> + test_when_finished "git reset --hard && git checkout master" && >>> + git config log.showsignature false && >> >> Any specific reason as to why you don't use test_config like in the >> first test? > > None, actually. It was just that I forgot to use test_config while > writing the tests. I will make changes accordingly as test_config > automatically unset the config variable, which is necessary.
Or you could probably use 'git -c' which makes it all the more compact.
Regards, Pranit Bauva