Re: [RFC/PATCH 1/2] log: add "log.showsignature" configuration variable

From: Mehul Jain <mehul.jain2029@gmail.com>
Date: May 26, 2016, 15:04 UTC
Message-ID: <CA+DCAeSYr-q-0uSeDymJPHZwVZDZhh4yHH48peLOKodbxW1N7A@mail.gmail.com>
In-Reply-To: <156149583.51074.1464270131166.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Hi Remi,

Thanks for your input.

On Thu, May 26, 2016 at 7:12 PM, Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:

Show 6 quoted lines

> Hi Mehul,
>
> Mehul Jain <mehul.jain2029@gmail.com> writes:
>> When log.showsignature set true, "git log" and "git show" will behave
>
> 'When log.showsignature is set to true' ?

Pardon me, but I don't understand your question. I think you are suggesting me to write "When log.showsignature is set to true" instead of "When log.showsignature set true".

Show 6 quoted lines

>> +test_expect_success GPG '--show-signature overrides log.showsignature=false' '
>> +        test_when_finished "git reset --hard && git checkout master" &&
>> +        git config log.showsignature false &&
>
> Any specific reason as to why you don't use test_config like in the
> first test?

None, actually. It was just that I forgot to use test_config while writing the tests. I will make changes accordingly as test_config automatically unset the config variable, which is necessary.

Thanks, Mehul