Re: [PATCH v6 01/16] Git.pm: add subroutines for commenting lines

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 13, 2016, 18:15 UTC
Message-ID: <xmqqinqn4rwu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1481627820.2041.21.camel@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

Show 9 quoted lines

>> We only update comment_line_char from the default "#" when the
>> configured value is a single-byte character and we ignore incorrect
>> values in the configuration file. So I think the patch you sent is
>> correct after all.
>
> I am still not sure what version do we prefer.
>
> Check whether core.commentchar is a single character. If not, use '#'
> as the $comment_line_char.

This, plus special casing "auto".

Picking the first byte is inconsistent with the current practice (the paragraph you quoted above), I think.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.