Re: [PATCH v6 01/16] Git.pm: add subroutines for commenting lines

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 9, 2016, 17:32 UTC
Message-ID: <alpine.DEB.2.20.1612091832310.23160@virtualbox>
In-Reply-To: <1481303956.4934.8.camel@sapo.pt>

Hi Vasco,

On Fri, 9 Dec 2016, Vasco Almeida wrote:

Show 14 quoted lines

> A Ter, 22-11-2016 às 09:42 -0800, Junio C Hamano escreveu:
> > The incremental update below looks sensible.  We'd also want to
> > protect this codepath from a misconfigured two-or-more byte sequence
> > in core.commentchar, I would suspect, to be consistent.
> 
> Are the below changes alright for what you propose? It just checks if
> the length of core.commentchar's value is 1, otherwise use '#' as the
> comment_line_char.
> As a note, when I set core.commentchar with "git config
> core.commentChar 'batata'", I get the following error message when I
> issue "git add -i":
> 
> error: core.commentChar should only be one character
> fatal: bad config variable 'core.commentchar' in file '.git/config' at line 6

This is exactly the same issue I fixed for rebase -i recently.

Good eyes, Dscho