From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Dec 2016 18:15:13 GMT
Subject: Re: [PATCH v6 01/16] Git.pm: add subroutines for commenting lines
Message-ID: <xmqqinqn4rwu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1481627820.2041.21.camel@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

>> We only update comment_line_char from the default "#" when the
>> configured value is a single-byte character and we ignore incorrect
>> values in the configuration file. So I think the patch you sent is
>> correct after all.
>
> I am still not sure what version do we prefer.
>
> Check whether core.commentchar is a single character. If not, use '#'
> as the $comment_line_char.

This, plus special casing "auto".

Picking the first byte is inconsistent with the current practice
(the paragraph you quoted above), I think.