Re: [RFC PATCH v5 4/8] Extract functions out of git_rebase__interactive

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2018, 22:22 UTC
Message-ID: <xmqqin9mh1pq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <baf0d9bab81bb3a80d0428c4aaa33cf32b3823e4.1521839546.git.wink@saville.com>

Wink Saville <wink@saville.com> writes:

Show 13 quoted lines

> The extracted functions are:
>   - initiate_action
>   - setup_reflog_action
>   - init_basic_state
>   - init_revisions_and_shortrevisions
>   - complete_action
>
> Used by git_rebase__interactive
>
> Signed-off-by: Wink Saville <wink@saville.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---

I checked the correspondence of lines between the verison before and after the patch, and did not spot anything suspicious. The fact that we do not use "local" and stick to POSIX shell helps a bit, as we do not have to worry about "does this $variable in the split-out function refer to the same data as the original?" ;-)

Will queue.