Re: [RFC PATCH v5 0/8] rebase-interactive

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2018, 22:27 UTC
Message-ID: <xmqqefkah1gl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <cover.1521839546.git.wink@saville.com>

Wink Saville <wink@saville.com> writes:

Show 9 quoted lines

> Wink Saville (8):
>   rebase-interactive: simplify pick_on_preserving_merges
>   rebase: update invocation of rebase dot-sourced scripts
>   Indent function git_rebase__interactive
>   Extract functions out of git_rebase__interactive
>   Add and use git_rebase__interactive__preserve_merges
>   Remove unused code paths from git_rebase__interactive
>   Remove unused code paths from git_rebase__interactive__preserve_merges
>   Remove merges_option and a blank line

I felt that the structure of steps 5-7 that adds an identical copy first and then removes irrelevant parts from both copies was a bit unusual, but I do not think of a better structure I would use if I were doing this series myself, and more importantly, the entire series was a pleasant and straight-forward read.

Will queue and wait for input from others.

Thanks.