Re: [RFC PATCH v4] rebase: Update invocation of rebase dot-sourced scripts

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 23, 2018, 21:18 UTC
Message-ID: <CAPig+cT=0-+zgyGP7NEL3FFrc9bTDe9JLugoBqiFo5BtJq=2PQ@mail.gmail.com>
In-Reply-To: <xmqqbmfeik0i.fsf@gitster-ct.c.googlers.com>

On Fri, Mar 23, 2018 at 5:01 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
>> (despite the run-on sentence in the first paragraph and the apparent
>> incorrect explanation of top-level "return" misbehavior -- the in-code
>> comment says top-level "return" was essentially a no-op in broken
>> shells, whereas he said it exited the shell).
>
> My bad, almost entirely.  Sorry.

No apology necessary. That minor error aside, your proposed commit message gave just the right amount of detail for a person (me) not at all familiar with the topic to be able to understand it fully and intuit the patch content before even reading the patch proper. That's a good commit message.